Skip to content

feat: additional NATS auth options#1315

Open
mfreeman451 wants to merge 7 commits intofalcosecurity:masterfrom
mfreeman451:feature/nats-enhanced-auth
Open

feat: additional NATS auth options#1315
mfreeman451 wants to merge 7 commits intofalcosecurity:masterfrom
mfreeman451:feature/nats-enhanced-auth

Conversation

@mfreeman451
Copy link
Copy Markdown

@mfreeman451 mfreeman451 commented Mar 3, 2026 •
edited
Loading

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1316

Special notes for your reviewer:

@mfreeman451 mfreeman451 marked this pull request as draft March 3, 2026 05:20
@poiana
Copy link
Copy Markdown

poiana commented Mar 3, 2026

Welcome @mfreeman451! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@poiana poiana requested a review from fjogeleit March 3, 2026 05:20
@poiana
Copy link
Copy Markdown

poiana commented Mar 3, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mfreeman451
Once this PR has been reviewed and has the lgtm label, please assign issif for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested a review from leogr March 3, 2026 05:20
mfreeman451
mfreeman451 commented Mar 3, 2026
View reviewed changes
Copy link
Copy Markdown
Author

@mfreeman451 mfreeman451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mfreeman451 mfreeman451 force-pushed the feature/nats-enhanced-auth branch from 85c168f to 11e0dcb Compare March 3, 2026 06:04
@mfreeman451
Copy link
Copy Markdown
Author

mfreeman451 commented Mar 3, 2026

/kind feature

@poiana poiana added kind/feature New feature or request and removed needs-kind labels Mar 3, 2026
@mfreeman451
Copy link
Copy Markdown
Author

mfreeman451 commented Mar 3, 2026

/area outputs

@mfreeman451 mfreeman451 mentioned this pull request Mar 3, 2026
Open
3 tasks
@mfreeman451 mfreeman451 marked this pull request as ready for review March 3, 2026 06:08
@poiana poiana requested a review from cpanato March 3, 2026 06:08
leogr
leogr reviewed Mar 6, 2026
View reviewed changes
Comment thread outputs/nats.go Outdated
leogr
leogr reviewed Mar 6, 2026
View reviewed changes
Comment thread outputs/nats.go Outdated
Comment thread outputs/nats.go Outdated
Comment thread main.go
@mfreeman451 mfreeman451 force-pushed the feature/nats-enhanced-auth branch from 358b419 to 686f4e2 Compare March 13, 2026 01:43
@mfreeman451 mfreeman451 force-pushed the feature/nats-enhanced-auth branch from 686f4e2 to 58362c6 Compare March 13, 2026 01:44
mfreeman451
mfreeman451 commented Mar 13, 2026
View reviewed changes
Copy link
Copy Markdown
Author

@mfreeman451 mfreeman451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leogr
Copy link
Copy Markdown
Member

leogr commented Mar 16, 2026

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository. Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Details

Hey @mfreeman451

Per our policy, merge commits are not allowed. Here's a quick guide to rebase properly: https://github.com/falcosecurity/.github/blob/main/CONTRIBUTING.md#resolving-conflicts-by-rebasing

mfreeman451 and others added 7 commits March 16, 2026 15:45
@mfreeman451
feat: additional nats auth options
d166fcc 
Signed-off-by: Michael Freeman <mfreeman451@gmail.com>
@mfreeman451
chore: restoring TOC
16bcef6 
Signed-off-by: Michael Freeman <mfreeman451@gmail.com>
@mfreeman451
fix: nats output
179dde3 
Signed-off-by: Michael Freeman <mfreeman451@gmail.com>
@mfreeman451
chore: restore TOC
2dbefae 
Signed-off-by: Michael Freeman <mfreeman451@gmail.com>
@mfreeman451 @leogr
Update outputs/nats.go
d9e5161 
Co-authored-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Michael Freeman <mfreeman@carverauto.dev>
Signed-off-by: Michael Freeman <mfreeman451@gmail.com>
@mfreeman451 @leogr
Update main.go
837d0a1 
Co-authored-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Michael Freeman <mfreeman@carverauto.dev>
Signed-off-by: Michael Freeman <mfreeman451@gmail.com>
@mfreeman451
chore: cleanup
3dda987 
Signed-off-by: Michael Freeman <mfreeman451@gmail.com>
@mfreeman451 mfreeman451 force-pushed the feature/nats-enhanced-auth branch from 58362c6 to 3dda987 Compare March 16, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leogr leogr leogr left review comments

@fjogeleit fjogeleit Awaiting requested review from fjogeleit

@cpanato cpanato Awaiting requested review from cpanato

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area/outputs dco-signoff: yes kind/feature New feature or request size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing NATS authentication options

3 participants

@mfreeman451 @poiana @leogr